feat: Add editable right sidebar with multi-row support#20
Merged
Conversation
- Implement editable fields in right sidebar for table rows - Add multi-row editing with 'Multiple values' support - Support SQL functions (NOW(), CURRENT_TIMESTAMP, etc.) - Add native macOS form styling with TextField and Menu - Include immediate save on Cmd+S - Handle NULL, DEFAULT, and SQL function values - Preserve edit state during data refresh to prevent UI flashing New files: - MultiRowEditState.swift for edit state management - EditableFieldView.swift for reusable field components Modified files: - RightSidebarView.swift with editable/readonly modes - MainContentView.swift with save handlers and SQL generation - MainContentCoordinator.swift with transaction support - MainContentView+Bindings.swift with sidebar state helpers
There was a problem hiding this comment.
Pull request overview
This PR implements an editable right sidebar for row editing, matching TablePlus behavior. The sidebar allows users to edit fields with native macOS styling, supports multi-row editing, SQL functions, NULL/DEFAULT values, and immediate save via Cmd+S.
Changes:
- Adds multi-row edit state management with field-level tracking
- Introduces editable field components with native macOS styling and menu support
- Updates sidebar view to switch between read-only and editable modes based on context
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| MultiRowEditState.swift | New state management class for tracking pending edits across multiple selected rows |
| EditableFieldView.swift | New reusable editable field component with native macOS styling and SQL function support |
| RightSidebarView.swift | Modified to support editable and read-only modes, integrating with the new edit state |
| MainContentView.swift | Added sidebar edit state management, save handlers, and SQL generation for updates |
| MainContentCoordinator.swift | Added transaction-based execution method for sidebar changes |
| MainContentView+Bindings.swift | Added helper properties for sidebar editability state |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ngô Quốc Đạt <datlechin@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ngô Quốc Đạt <datlechin@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ngô Quốc Đạt <datlechin@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ngô Quốc Đạt <datlechin@gmail.com>
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements editable right sidebar functionality matching TablePlus behavior.
Features
Files Changed